This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
fix/http: add logging middleware to default exported external http clients #64402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/SRC-507/make-sure-that-the-http-retries-log-some-info-about-requests-that-are
The core change in this PR is the following:
We already had existing HTTP middleware that logs retries, but many of the default exports (default Doer, client, etc.) didn't include this middleware by default:
https://github.com/sourcegraph/sourcegraph/blob/6136978b18306b5e41c77b5704a71da135db5ea9/internal/httpcli/client.go#L363-L412
This PR does all the grunt work of changing these default exports to be a function that accepts a logger (so that we can include the logging middleware by default). The vast majority of the changes are just passing new loggers as appropriate and fixing the resulting type errors.
Test plan
env SRC_LOG_LEVEL=debug sg start
and saw debug log lines from the middleware. Ex:Changelog